ENH: Move Motor Plots and Prints#387
Merged
Gui-FernandesBR merged 8 commits intoenh/liquid-motorsfrom Jun 30, 2023
Merged
Conversation
Gui-FernandesBR
added
Refactor
Outputs
Member
|
The following issue can/may be fixed with this PR, saving here for later :)
|
enh/move-liquid-plots-and-prints
- Sort imports - avoid printing blank lines - more prints and plots for tank geometry
Member
Gui-FernandesBR
approved these changes
Jun 30, 2023
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Well done @MateusStano !!
The changes that I considered important, I already implemented in the last two commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is new?
One more PR to move the plots and prints. Few important notes
The plots and prints file of the classes
Tank,TankGeometryandFluiddo not print or plot anything. This is because those classes do not have any plots or prints. They will eventually get proper prints and plots, so the structure is already there for when it is needed.I made it so, in the motor plots files, the plot methods receive the limits of the x axis of the plot. I think this is really useful and should be implemented in all other classes in some other PR